-
-
Notifications
You must be signed in to change notification settings - Fork 146
Display the date of last edit #2838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Resolves #2835 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
02ddffe
to
433091e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, we should instead go for something like Signal does, which is a nice relevant mix of relative for recent times and absolute for older times:
- 59 minutes ago or younger: "Xm"
- 23 hours ago or younger: "Xh"
- 6 days ago or younger: Sat, Sun, Mon etc
- 364 days ago or younger: Sep 12, Jan 12 etc
- Anything older: Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice short form date! :) Love it!
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
0869da1
to
3cd6e17
Compare
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/2838.apk |
|
||
// Nextcloud SSO | ||
implementation 'com.github.nextcloud.android-common:ui:0.28.0' | ||
implementation 'com.github.nextcloud.android-common:ui:49be0069f6' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we keep it like that?
Renovate will bump to 0.29.0 once it is released, I assume.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We now merged it to masters, test has beendet written and I did not another PR, so yeah, we can als o pin on the commit for the moment or do a release of the lib some time next week.
Resolves #2835
Depends on nextcloud/android-common#771