Skip to content

chore: Port to composer-bin #1618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

chore: Port to composer-bin #1618

wants to merge 2 commits into from

Conversation

CarlSchwan
Copy link
Member

No description provided.

chore(workflows): Update psalm workflow
29c52cc 
Signed-off-by: Carl Schwan <carl.schwan@nextclound.com>
enjeck
enjeck reviewed Sep 15, 2025
View reviewed changes
Copy link
Contributor

@enjeck enjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @CarlSchwan . Is there a benefit for doing this?

@CarlSchwan
Copy link
Member Author

Thanks, @CarlSchwan . Is there a benefit for doing this?

It isolates all the tools (unittests, psalm, ...) from the actual server so that they are not loaded by mistakes and also makes it more similar to how other apps work.

But this requires a bit more change to actually work. I'll put that back to draft

@CarlSchwan CarlSchwan marked this pull request as draft September 15, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enjeck enjeck enjeck left review comments

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter JuliaKirschenheuter is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CarlSchwan @enjeck