feat: improve attachment storage for API #1633
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheywood
requested review from
JuliaKirschenheuter and
enjeck
as code owners
cheywood
force-pushed
the
improve-attachment-storage
branch
from
bdc2b65 to
3c4d132
Compare
- Attachments are stored in note-specific folder - Attachment filenames are retained This mirrors the behaviour for attachments created in the web UI.
cheywood
force-pushed
the
improve-attachment-storage
branch
from
3c4d132 to
a4d6891
Compare
|
Thanks @enjeck! 🙏 Once this is resolved I'll get a release of Iotas out using the API :) |
|
Oh hrmm yeah reading back through the discussion I picked up that this impacts moving notes between categories too; without this fix the attachments are left in the previous location, disconnected from the note. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors the behaviour for attachments created in the web UI, bringing the following benefits:
Most of the code is based on what's used in Text.
If the API wasn't already public I would switch the name of the return element for image creation to
path(fromfilename). As there likely isn't any project consuming the API yet this may not be a bad idea.Addresses part of #1623.