Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: filter notes by category #518

Merged
merged 5 commits into from
May 22, 2020
Merged

API: filter notes by category #518

merged 5 commits into from
May 22, 2020

Conversation

korelstar
Copy link
Member

@korelstar korelstar commented May 20, 2020 •
edited
Loading

fixes #510

  • filter notes by category (API v 1.1)
  • change docs
  • add tests

@korelstar korelstar added the feature: API Related to the API for 3rd-party apps, i.e. Android or iOS label May 20, 2020
@korelstar korelstar added this to the 3.4.0 milestone May 20, 2020
@korelstar korelstar requested a review from tobiasKaminsky May 20, 2020 09:34
@korelstar korelstar mentioned this pull request May 20, 2020
Closed
tobiasKaminsky
tobiasKaminsky approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@tobiasKaminsky tobiasKaminsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea about code, but tested and works :)
(I only tested it with categories without spaces or special chars

@korelstar
Copy link
Member Author

Just fixed a bug: the resulting JSON is always a JSON-list, but was sometimes a JSON-object.

@korelstar korelstar marked this pull request as ready for review May 22, 2020 09:34
@korelstar korelstar merged commit e2f4e30 into master May 22, 2020
@korelstar korelstar deleted the api-by-category branch May 22, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

Assignees
No one assigned
Labels
feature: API Related to the API for 3rd-party apps, i.e. Android or iOS
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

API: get all notes of a specific category
2 participants
@korelstar @tobiasKaminsky