Skip to content

Commit

Permalink
refactor(OC_Template): Remove deprecated ILogger
Browse files Browse the repository at this point in the history
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
  • Loading branch information
susnux committed Sep 18, 2024
1 parent 74923d1 commit f1dfd6b
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions lib/private/legacy/OC_Template.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
use OCP\AppFramework\Http\Events\BeforeTemplateRenderedEvent;
use OCP\AppFramework\Http\TemplateResponse;
use OCP\EventDispatcher\IEventDispatcher;
use Psr\Log\LoggerInterface;

require_once __DIR__.'/template/functions.php';

Expand Down Expand Up @@ -242,10 +243,10 @@ public static function printErrorPage($error_msg, $hint = '', $statusCode = 500)
\OC::$server->get(IEventDispatcher::class)->dispatchTyped($event);
print($response->render());
} catch (\Throwable $e1) {
$logger = \OC::$server->getLogger();
$logger->logException($e1, [
$logger = \OCP\Server::get(LoggerInterface::class);
$logger->error('Rendering themed error page failed. Falling back to un-themed error page.', [
'app' => 'core',
'message' => 'Rendering themed error page failed. Falling back to unthemed error page.'
'exception' => $e1,
]);

try {
Expand All @@ -256,9 +257,9 @@ public static function printErrorPage($error_msg, $hint = '', $statusCode = 500)
} catch (\Exception $e2) {
// If nothing else works, fall back to plain text error page
$logger->error("$error_msg $hint", ['app' => 'core']);
$logger->logException($e2, [
$logger->error('Rendering un-themed error page failed. Falling back to plain text error page.', [
'app' => 'core',
'message' => 'Rendering unthemed error page failed. Falling back to plain text error page.'
'exception' => $e2,
]);

header('Content-Type: text/plain; charset=utf-8');
Expand Down Expand Up @@ -296,9 +297,9 @@ public static function printExceptionErrorPage($exception, $statusCode = 503) {
$content->printPage();
} catch (\Exception $e) {
try {
$logger = \OC::$server->getLogger();
$logger->logException($exception, ['app' => 'core']);
$logger->logException($e, ['app' => 'core']);
$logger = \OCP\Server::get(LoggerInterface::class);
$logger->error($exception->getMessage(), ['app' => 'core', 'exception' => $exception]);
$logger->error($e->getMessage(), ['app' => 'core', 'exception' => $e]);
} catch (Throwable $e) {
// no way to log it properly - but to avoid a white page of death we send some output
self::printPlainErrorPage($e, $debug);
Expand Down

0 comments on commit f1dfd6b

Please sign in to comment.