New command to update group mappings (#26341) #1840
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
|
@rullzer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @blizzz, @owncloud-bot and @nickvergessen to be potential reviewers. |
nickvergessen
requested changes
Oct 21, 2016
| @@ -53,3 +53,4 @@ | |||
| $application->add(new OCA\User_LDAP\Command\CheckUser( | |||
| $uBackend, $helper, $deletedUsersIndex, $userMapping) | |||
| ); | |||
| $application->add(new OCA\User_LDAP\Command\UpdateGroup(new LDAP(), $helper, $dbConnection)); | |||
There was a problem hiding this comment.
Let me do that for LDAP in a new PR for all commands
| */ | ||
| private function updateGroupMapping($groupName, $userList) { | ||
| $query = $this->connection->getQueryBuilder(); | ||
| $needToInsert = false; |
| $result = $query->select('*') | ||
| ->from('ldap_group_members') | ||
| ->where($query->expr()->eq('owncloudname', $query->createParameter('group'))) | ||
| ->setParameter('group', $groupName) |
There was a problem hiding this comment.
use createNamedParameter($groupName) to save one row for each usage?
| ->setValue('owncloudname', $query2->createParameter('group')) | ||
| ->setValue('owncloudusers', $query2->createParameter('users')) | ||
| ->setParameter('group', $groupName) | ||
| ->setParameter('users', serialize($userList)) |
There was a problem hiding this comment.
please dont use serialize but json_encode/decode instead.
unserialize has security issues
| ->setName('ldap:update-group') | ||
| ->setDescription('update the specified group membership information stored locally') | ||
| ->addArgument( | ||
| 'groupID', |
| const ERROR_CODE_MISSING_CONF = 1; | ||
| const ERROR_CODE_MISSING_MAPPING = 2; | ||
|
|
||
| public function __construct(LDAP $ldap, Helper $helper, IDBConnection $connection) { |
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
|
👎 too much bad code |
|
@blizzz okidoki then I'll close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See owncloud/core#26341
CC: @blizzz @MorrisJobke @nickvergessen