Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port files trashbin events to IEventDispatcher/IEventListener #32018

Merged
merged 4 commits into from
Sep 24, 2024

fix(tests): Pause trashbin for lock tests in ViewTest using rmdir and…

4adf5fd
Select commit
Loading
Failed to load commit list.
Merged

Port files trashbin events to IEventDispatcher/IEventListener #32018

fix(tests): Pause trashbin for lock tests in ViewTest using rmdir and…
4adf5fd
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / Psalm succeeded Sep 24, 2024 in 26s

2 new alerts

New alerts in code changed by this pull request

  • 2 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 31 in apps/files_trashbin/lib/Listener/EventListener.php

See this annotation in the file changed.

Code scanning / Psalm

RiskyTruthyFalsyComparison Note

Operand of type null|string contains type string, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead.

Check notice on line 1177 in apps/files_trashbin/lib/Trashbin.php

See this annotation in the file changed.

Code scanning / Psalm

RedundantConditionGivenDocblockType Note

Docblock-defined type OCP\Files\Events\Node\BeforeNodeDeletedEvent for $event is always OCP\Files\Events\Node\BeforeNodeDeletedEvent