Refactors lib/private/SystemTag #38995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
requested review from
blizzz,
a team,
ArtificialOwl and
nfebe
and removed request for
a team
blizzz
approved these changes
Jul 10, 2023
fsamapoor
force-pushed
the
refactor_lib_private_systemtag
branch
from
dac222c
to
6b5dc11
Compare
fsamapoor
force-pushed
the
refactor_lib_private_systemtag
branch
from
6b5dc11
to
9850ef4
Compare
|
Apps acceptance tests fail. It's probably unrelated. But maybe let's rebase the branch later for another CI run or check if other recent PRs show the same error? |
Sure. Thank you for taking the time. |
fsamapoor
force-pushed
the
refactor_lib_private_systemtag
branch
from
9850ef4
to
5d4e1a1
Compare
Merged
Merged
Mainly using PHP8's constructor property promotion. Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
fsamapoor
force-pushed
the
refactor_lib_private_systemtag
branch
from
5d4e1a1
to
a988754
Compare
|
@ChristophWurst Finally, no acceptance failure! |
ChristophWurst
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following previous PRs taking advantage of PHP8's constructor property promotion in
/core/namespace, I have also made the required adjustments to the classes in/lib/private/SystemTagnamespace.The improvements in this PRs include: