-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support opening and comparing versions in viewer #39171
Support opening and comparing versions in viewer #39171
Conversation
b26cb7c
to
81ce076
Compare
81ce076
to
c148c5a
Compare
c148c5a
to
64c5835
Compare
397567d
to
81d89f1
Compare
81d89f1
to
4611ce2
Compare
4611ce2
to
92d7b38
Compare
92d7b38
to
872843c
Compare
/compile |
Signed-off-by: Louis Chemineau <louis@chmn.me>
c7d8439
to
5902325
Compare
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
/backport 5902325 to stable27 |
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
/backport 5902325 to stable27 |
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Backport bot is no friend of mine nor of @juliushaertl 😭 |
Fix #39139
Fix #39140
Tests will be added in text as there is no default viewer handler that covers version comparison support for now
Screenshots
Clicking the version just opens a single preview
Comparing menu
Comparing is available for any but the current version
Clicking it will compare the picked with the current version
Todo