Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor user_ldap group membership cache and add check-group command #39446

Merged
merged 17 commits into from
Aug 10, 2023
Merged

Refactor user_ldap group membership cache and add check-group command #39446

merged 17 commits into from
Aug 10, 2023

Commits on Aug 10, 2023

  1. Refactor user_ldap group membership to use flat DB 

    Move away from serialized arrays. Also use a QBMapper class for the new table.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
    @come-nc
    come-nc committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    d8142b6 View commit details
    Browse the repository at this point in the history

  2. Update autoloader mapping for user_ldap 

    Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
    @come-nc
    come-nc committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    d9b3680 View commit details
    Browse the repository at this point in the history

  3. Add group events to UpdateGroups 

    Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
    @come-nc
    come-nc committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    34fa413 View commit details
    Browse the repository at this point in the history

  4. Move UpdateGroups methods to a service 

    Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
    @come-nc
    come-nc committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    2c19aac View commit details
    Browse the repository at this point in the history

  5. Add check-group command 

    Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
    @come-nc
    come-nc committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    f9ed48e View commit details
    Browse the repository at this point in the history

  6. Add missing primary key for ldap_group_membership 

    Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
    @come-nc
    come-nc committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    ec13f22 View commit details
    Browse the repository at this point in the history

  7. Fix errors in UpdateGroupsService.php 

    Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
    @come-nc
    come-nc committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    1b102ca View commit details
    Browse the repository at this point in the history

  8. Always empty cache before updating a group 

    Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
    @come-nc
    come-nc committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    ce5a4e5 View commit details
    Browse the repository at this point in the history

  9. Add output to check-group --update command 

    Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
    @come-nc
    come-nc committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    7a14aa7 View commit details
    Browse the repository at this point in the history

  10. Fix getKnownGroups return value 

    Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
    @come-nc
    come-nc committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    42448c0 View commit details
    Browse the repository at this point in the history

  11. Fix check-group command for new groups 

    Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
    @come-nc
    come-nc committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    1026b21 View commit details
    Browse the repository at this point in the history

  12. [user_ldap] Small perf improvements suggestion from review 

    Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
    @come-nc
    come-nc committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    c33c40f View commit details
    Browse the repository at this point in the history

  13. Dispatch UserRemovedEvents for removed groups 

    Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
    @come-nc
    come-nc committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    ad1e487 View commit details
    Browse the repository at this point in the history

  14. Removed GroupCreatedEvent/GroupDeletedEvent from UpdateGroupsService 

    This should be handled when mapping groups, not when registering their
 members. An empty group may still exist.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
    @come-nc
    come-nc committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    7732de7 View commit details
    Browse the repository at this point in the history

  15. Use BIGINT for new table id field 

    Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
    @come-nc
    come-nc committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    5425f7d View commit details
    Browse the repository at this point in the history

  16. Fix check-group --update for deleted groups 

    Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
    @come-nc
    come-nc committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    b8a0954 View commit details
    Browse the repository at this point in the history

  17. Add unique index for user_ldap group memberships 

    Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
    @come-nc
    come-nc committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    a080811 View commit details
    Browse the repository at this point in the history