Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to nextcloud-vue 8 (beta) #39540

Merged
merged 8 commits into from
Aug 2, 2023
Merged

Update to nextcloud-vue 8 (beta) #39540

merged 8 commits into from
Aug 2, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 23, 2023

Summary

Now that we migrated from every deprecated component for nextcloud-vue 8 we can update master to version 8 beta.

This includes all changes listed here nextcloud-libraries/nextcloud-vue#4223

Checklist

@susnux susnux added this to the Nextcloud 28 milestone Jul 23, 2023
@susnux susnux requested review from skjnldsv, Pytal, a team and szaimen and removed request for a team July 23, 2023 00:30
@susnux susnux changed the title Feat/migrate nc vue 8 Update to nextcloud-vue 8 (beta) Jul 23, 2023
@susnux susnux requested review from artonge and ShGKme July 23, 2023 00:47
@susnux susnux force-pushed the feat/migrate-nc-vue-8 branch 2 times, most recently from 3488bc7 to acd7065 Compare July 23, 2023 20:31
@susnux susnux requested a review from ShGKme July 24, 2023 11:55
@susnux
Copy link
Contributor Author

susnux commented Jul 24, 2023

BTW I have no idea why cypress with browserify broke, but changing to webpack as preprocessor works and reduces the npm dependencies (~80 dependencies less).

ShGKme
ShGKme approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on:

  • Files
  • Sidebar, including
    • Comments
    • Versions
  • Settings, including
    • Apps
    • Users
    • Theming
  • Weather status

@skjnldsv
Copy link
Member

skjnldsv commented Aug 1, 2023

Please rebase 🙈

@susnux susnux force-pushed the feat/migrate-nc-vue-8 branch 2 times, most recently from bf3bd63 to 02d2977 Compare August 2, 2023 00:02
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish 2. developing Work in progress and removed 3. to review Waiting for reviews 4. to release Ready to be released and/or waiting for tests to finish labels Aug 2, 2023
susnux and others added 8 commits August 2, 2023 15:19
@susnux
chore: Update nextcloud-vue to v8 beta2 and renamed changed properties
663db2b 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix: Resolve code linting issues
4c306a3 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix(cypress): Make sure cypress can preprocess files corrently (this …
ee18e43 
…drops 78 dependencies)

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix(dav): Update jest snapshot for changed vue sidebar tab
5eb2a5d 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: Build assets
fab9f48 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix: Acceptance tests adjusted to find new style sidebar tabs
e457572 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@skjnldsv @susnux
fix(jest): also mock initial-state
9bf42fc 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@susnux
fix(cypress): Really mock the initial state instead of trying to stub…
6503125 
… a module

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added 3. to review Waiting for reviews 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress 3. to review Waiting for reviews labels Aug 2, 2023
@skjnldsv skjnldsv merged commit 8fa9607 into master Aug 2, 2023
37 checks passed
@skjnldsv skjnldsv deleted the feat/migrate-nc-vue-8 branch August 2, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@Pytal Pytal Pytal approved these changes

@ShGKme ShGKme ShGKme approved these changes

@szaimen szaimen Awaiting requested review from szaimen szaimen was automatically assigned from nextcloud/server-frontend

@artonge artonge Awaiting requested review from artonge

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish dependencies javascript
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
4 participants
@susnux @skjnldsv @Pytal @ShGKme