Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable25] fix share roots always being marked as writable #39671

Merged
merged 1 commit into from
Aug 3, 2023
Merged

[stable25] fix share roots always being marked as writable #39671

merged 1 commit into from
Aug 3, 2023

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented Aug 2, 2023

Backport of #39614

@nfebe nfebe changed the title Backport of #39614 [stable26] [27] fix share roots always being marked as writable Aug 2, 2023
@nfebe nfebe changed the title [stable26] [27] fix share roots always being marked as writable [stable25] [27] fix share roots always being marked as writable Aug 2, 2023
@solracsf solracsf changed the title [stable25] [27] fix share roots always being marked as writable [stable25] fix share roots always being marked as writable Aug 2, 2023
@solracsf solracsf added this to the Nextcloud 25.0.10 milestone Aug 2, 2023
nickvergessen
nickvergessen requested changes Aug 2, 2023
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't check the test file, but you can execute the test locally before pushing

lib/public/Files/DavUtil.php Outdated Show resolved Hide resolved
lib/public/Files/DavUtil.php Outdated Show resolved Hide resolved
@blizzz blizzz mentioned this pull request Aug 2, 2023
Merged
@icewind1991 @nickvergessen
fix share roots always being marked as writable
ee29ab1 
Signed-off-by: Robin Appelman <robin@icewind.nl>
nickvergessen
nickvergessen approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cherry-picked the original command from icewind and adjusted the : void in the test file which was the conflict.

@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed backport-request labels Aug 2, 2023
@nfebe nfebe enabled auto-merge August 2, 2023 23:37
@nfebe nfebe disabled auto-merge August 3, 2023 07:16
@nfebe nfebe merged commit 0f10006 into stable25 Aug 3, 2023
29 checks passed
@nfebe nfebe deleted the manual/backport/39614 branch August 3, 2023 07:16
@nfebe
Copy link
Contributor Author

nfebe commented Aug 3, 2023

CI, fail is erratic and unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz blizzz approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@GretaD GretaD Awaiting requested review from GretaD

@come-nc come-nc Awaiting requested review from come-nc

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish 25-feedback
Projects
None yet
Milestone
Nextcloud 25.0.10
Development

Successfully merging this pull request may close these issues.
7 participants
@nfebe @nickvergessen @ArtificialOwl @AndyScherzinger @blizzz @solracsf @icewind1991