Refactors files version app commands. #39695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 3, 2023 16:35
To improve code readability. Signed-off-by: Faraz Samapoor <fsa@adlas.at>
To improve code readability. Signed-off-by: Faraz Samapoor <fsa@adlas.at>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| $output->writeln("Remove deleted files of <info>$user</info>"); | ||
| $userObject = $this->userManager->get($user); | ||
| $this->expireVersionsForUser($userObject); |
Check notice
Code scanning / Psalm
PossiblyNullArgument Note
artonge
approved these changes
Aug 17, 2023
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
come-nc
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I have made some adjustments to the apps/files_version/lib/Command classes to improve the code readability.
The improvements in this PR include but are not limited to:
Checklist