Feat/26668/notifications for shared calendars 2 #39702
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
force-pushed
the
feat/26668/notifications-for-shared-calendars-2
branch
from
01dd5de
to
ca932b2
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Please don't forget to set the milestone when opening a PR 😃 |
skjnldsv
added
2. developing
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
kesselb
force-pushed
the
feat/26668/notifications-for-shared-calendars-2
branch
3 times, most recently
from
8a0fbe8
to
b00d01e
Compare
This is basically the original commit, but with the addition that shared calendars in to account and adjusts their uri s.t. the Sabre library can find the returned object uri in the user's calendar collection. Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de> Try to fix some psalm things. No change to the code apart from that. Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de> getCalendarObjectByUID(): prefer objects in shared writable calendars over private objects. Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de> fix: include the principalUri for dav_shares clause Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de> feat: use getPrincipalURI only for shared calendars Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
feat/26668/notifications-for-shared-calendars-2
branch
from
b00d01e
to
8e928ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fun fact: The default implementation for Sabre\CalDAV\Calendar.getOwner1 would always return the principaluri as owner. It's our overwrite in OCA\DAV\CalDAV\Calendar.getOwner2 causing the issues.
Issues
TODO
Checklist
Footnotes
https://github.com/sabre-io/dav/blob/85b33f7c4b597bdb2a90e6886a48c5723e767062/lib/CalDAV/Calendar.php#L229-L240 ↩
https://github.com/nextcloud/server/blob/780ece032fd42ec099d888a46a5349d8dea48dc2/apps/dav/lib/CalDAV/Calendar.php#L228-L232 ↩