-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppAPI: allow to bypass Two-Factor #42479
Conversation
if ($this->session->exists('app_password') || $this->twoFactorManager->isTwoFactorAuthenticated($user)) { | ||
if ($this->session->exists('app_password') | ||
|| $this->session->exists('app_api') | ||
|| $this->twoFactorManager->isTwoFactorAuthenticated($user)) { |
Check notice
Code scanning / Psalm
PossiblyNullArgument Note
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but didn't test
Please squash your commits into one
CI failure seems related, please fix and squash in this PR
|
ce4c53b
to
489b816
Compare
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
489b816
to
26d343d
Compare
/backport to stable28 |
/backport to stable27 |
Summary
AppAPI must support passing two-factor authentication so that ExApps can work in such systems.
By design they should do so.
Original issue where it was discovered(we just completely forgot about two-factor auth):
nextcloud/app_api#181
Since the context_chat was already released we should provide a fix for this situation.
Also the backport to stable28 branch is required, as this is a bug that blocks all Apps developed for AppAPI to work in most production systems.
If possible, also a backport to stable27 branch will be nice.
Ref:
Checklist