Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sharing): Don't change the type of the controller argument #44916

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

nickvergessen
Copy link
Member

[EA] New value type (\DateTime) is not matching the resolved parameter type and might introduce types-related false-positives.

grafik

Checklist

[EA] New value type (\DateTime) is not matching the resolved parameter type and might introduce types-related false-positives.

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

/backport! to stable29

@nickvergessen nickvergessen merged commit 2223e09 into master Apr 18, 2024
155 of 157 checks passed
@nickvergessen nickvergessen deleted the followup/44910/share-date-time branch April 18, 2024 13:51
@nfebe
Copy link
Contributor

nfebe commented Jun 10, 2024

/backport to stable27

Copy link

backportbot bot commented Jun 10, 2024

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b backport/44916/stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 490f5450

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/44916/stable27

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@nickvergessen
Copy link
Member Author

I did it here already: #45747

@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants