Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable27] fix(files_sharing): Add one string for every share type + fix(sharingDetails): Show correct share target #45873

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jun 14, 2024

Backport of #45024

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from artonge, susnux and nfebe June 14, 2024 08:26
@backportbot backportbot bot added this to the Nextcloud 27.1.11 milestone Jun 14, 2024
@solracsf solracsf changed the title [stable27] [stable28] fix(files_sharing): Add one string for every share type + fix(sharingDetails): Show correct share target [stable27] fix(files_sharing): Add one string for every share type + fix(sharingDetails): Show correct share target Jun 15, 2024
@nfebe nfebe force-pushed the backport/45024/stable27 branch 2 times, most recently from c488cb4 to ac3d8a6 Compare June 17, 2024 09:43
@nfebe nfebe marked this pull request as ready for review June 17, 2024 09:44
@nfebe
Copy link
Contributor

nfebe commented Jun 17, 2024

/compile

@blizzz blizzz mentioned this pull request Jun 17, 2024
3 tasks
@skjnldsv skjnldsv mentioned this pull request Jun 20, 2024
4 tasks
@blizzz blizzz mentioned this pull request Jun 24, 2024
@blizzz blizzz removed this from the Nextcloud 27.1.11 milestone Jun 24, 2024
susnux and others added 2 commits July 15, 2024 10:44
… any language

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
The share details page should show the target email or user/server to which

the user is creating the share.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@nfebe
Copy link
Contributor

nfebe commented Jul 15, 2024

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failed tests are the known flaky ones

@sorbaugh sorbaugh merged commit 44644b6 into stable27 Jul 15, 2024
37 of 39 checks passed
@sorbaugh sorbaugh deleted the backport/45024/stable27 branch July 15, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants