-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Mailer): Fix sendmail binary fallback #46480
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshtrichards
added
2. developing
Work in progress
and removed
3. to review
Waiting for reviews
labels
Jul 12, 2024
4 tasks
joshtrichards
force-pushed
the
fix/mailer-binaryfinder-fallback
branch
from
July 14, 2024 11:52
a5711cb
to
cbe57b5
Compare
joshtrichards
changed the title
fix(Mailer): Adjust fallback for current BinaryFinder return values
fix(Mailer): Fix sendmail binary fallback
Jul 14, 2024
8 tasks
/backport to stable29 |
/backport to stable28 |
joshtrichards
force-pushed
the
fix/mailer-binaryfinder-fallback
branch
2 times, most recently
from
July 18, 2024 15:55
2dc14cb
to
f8a2ece
Compare
joshtrichards
added
3. to review
Waiting for reviews
feature: emails
and removed
2. developing
Work in progress
labels
Jul 18, 2024
skjnldsv
approved these changes
Jul 27, 2024
skjnldsv
approved these changes
Jul 27, 2024
skjnldsv
requested review from
a team,
ArtificialOwl,
icewind1991 and
yemkareems
and removed request for
a team
July 27, 2024 14:40
Merged
joshtrichards
added
2. developing
Work in progress
and removed
3. to review
Waiting for reviews
labels
Sep 7, 2024
icewind1991
approved these changes
Sep 16, 2024
feat: add debug logging to sendmail binary finder Signed-off-by: Josh <josh.t.richards@gmail.com>
icewind1991
force-pushed
the
fix/mailer-binaryfinder-fallback
branch
from
September 16, 2024 13:20
f8a2ece
to
87aa126
Compare
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The non-deprecated BinaryFinder returns
false
notnull
when the fallback is needed (versus the deprecated one inOC_Helper
):server/lib/private/BinaryFinder.php
Line 45 in 465ad2f
Also add debug logging of which binary is found and fix test.
Some historical context:
TODO
Checklist