Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Mailer): Fix sendmail binary fallback #46480

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Jul 12, 2024

Summary

The non-deprecated BinaryFinder returns false not null when the fallback is needed (versus the deprecated one in OC_Helper):

public function findBinaryPath(string $program) {

Also add debug logging of which binary is found and fix test.

Some historical context:

TODO

  • Maybe: update tests to catch this sort of thing

Checklist

@joshtrichards joshtrichards added bug 3. to review Waiting for reviews labels Jul 12, 2024
@joshtrichards joshtrichards added this to the Nextcloud 30 milestone Jul 12, 2024
@joshtrichards joshtrichards added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 12, 2024
@joshtrichards joshtrichards force-pushed the fix/mailer-binaryfinder-fallback branch from a5711cb to cbe57b5 Compare July 14, 2024 11:52
@joshtrichards joshtrichards changed the title fix(Mailer): Adjust fallback for current BinaryFinder return values fix(Mailer): Fix sendmail binary fallback Jul 14, 2024
@joshtrichards
Copy link
Member Author

/backport to stable29

@joshtrichards
Copy link
Member Author

/backport to stable28

@joshtrichards joshtrichards force-pushed the fix/mailer-binaryfinder-fallback branch 2 times, most recently from 2dc14cb to f8a2ece Compare July 18, 2024 15:55
@joshtrichards joshtrichards added 3. to review Waiting for reviews feature: emails and removed 2. developing Work in progress labels Jul 18, 2024
@skjnldsv skjnldsv requested review from a team, ArtificialOwl, icewind1991 and yemkareems and removed request for a team July 27, 2024 14:40
This was referenced Jul 30, 2024
This was referenced Aug 5, 2024
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
@skjnldsv skjnldsv modified the milestones: Nextcloud 30, Nextcloud 31 Aug 14, 2024
@joshtrichards joshtrichards added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 7, 2024
feat: add debug logging to sendmail binary finder

Signed-off-by: Josh <josh.t.richards@gmail.com>
@icewind1991 icewind1991 force-pushed the fix/mailer-binaryfinder-fallback branch from f8a2ece to 87aa126 Compare September 16, 2024 13:20
@icewind1991 icewind1991 merged commit ede0c26 into master Sep 16, 2024
175 checks passed
@icewind1991 icewind1991 deleted the fix/mailer-binaryfinder-fallback branch September 16, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: nextcloud 29.0.3 mail_smtpmode sendmail doesn't fork /usr/sbin/sendmail
3 participants