Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sidebar): Show node owner in metadata subline #46691

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented Jul 22, 2024

Summary

Show user bubble to indicate owner of file in sidebar overview (this should not change irrespective of share status)...

Resolves: #46178

Screenshots

Timeline State
Before metadata-before
Now (owned by you) metadata-owned-by-you
Now (owned by other) metadata-owned-by-other

TODO

  • Finish wip
  • Screenshots

@nfebe
Copy link
Contributor Author

nfebe commented Jul 25, 2024

Show original file owner in side bar

Now that some logic to show the owner is in place with a simple "draft" to show this information with the userbubble near other folder metada can @nextcloud/designers chime in?

show-admin

@nfebe nfebe marked this pull request as ready for review July 25, 2024 02:55
@nfebe nfebe requested a review from skjnldsv as a code owner July 25, 2024 02:55
@nfebe nfebe requested review from susnux and artonge July 25, 2024 02:55
@nimishavijay
Copy link
Member

Nice! Good idea using the user bubble component. I would suggest we include only the username in the user bubble, and to separate the different metadata we could use a middle dot ·. So it would look like

11.2 MB · 3 weeks ago · Owned by (👱🏼 Alex Doe)

Also the user bubble component should be center aligned with the rest of the text :)

@skjnldsv skjnldsv marked this pull request as draft July 25, 2024 09:20
@nfebe nfebe marked this pull request as ready for review July 26, 2024 02:30
@nfebe nfebe force-pushed the fix-show-original-owner branch 2 times, most recently from 9c1c432 to 1a55a34 Compare July 27, 2024 01:37
@nfebe nfebe changed the title Wip : Show owner information in sidebar feat(sidebar): Show node owner in metadata subline Jul 27, 2024
@skjnldsv skjnldsv removed the 3. to review Waiting for reviews label Jul 27, 2024
apps/files/src/views/Sidebar.vue Outdated Show resolved Hide resolved
apps/files/src/views/Sidebar.vue Outdated Show resolved Hide resolved
@sorbaugh sorbaugh added this to the Nextcloud 31 milestone Aug 14, 2024
apps/files/src/views/Sidebar.vue Outdated Show resolved Hide resolved
apps/files/src/views/Sidebar.vue Outdated Show resolved Hide resolved
apps/files/src/views/Sidebar.vue Show resolved Hide resolved
apps/files/src/views/Sidebar.vue Outdated Show resolved Hide resolved
@nfebe nfebe force-pushed the fix-show-original-owner branch 2 times, most recently from cb22b2d to 908165a Compare September 19, 2024 09:35
@nfebe nfebe requested a review from artonge September 20, 2024 11:58
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to migrate the Sidebar to use proper Node data instead of legacy stuff, but until then this is probably the best way without patching legacy OC.Files.Client

Resolves: #46178

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@nfebe
Copy link
Contributor Author

nfebe commented Oct 7, 2024

/compile

@nfebe
Copy link
Contributor Author

nfebe commented Oct 7, 2024

/backport to stable30

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nfebe nfebe merged commit fcbb064 into master Oct 7, 2024
118 checks passed
@nfebe nfebe deleted the fix-show-original-owner branch October 7, 2024 14:19
Copy link
Contributor

github-actions bot commented Nov 3, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

[App Files] Can't see owner's name if a file/folder is reshared twice
10 participants