Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(psalm): named attribute argument #46846

Merged
merged 1 commit into from
Jul 29, 2024
Merged

fix(psalm): named attribute argument #46846

merged 1 commit into from
Jul 29, 2024

Conversation

ArtificialOwl
Copy link
Member

fix an error displayed during psalm static code analysis from #46476:

Error: apps/theming/lib/Controller/ThemingController.php:426:4: InvalidDocblock: Attribute arguments must be named. (see https://psalm.dev/008)

origin: #46819

@ArtificialOwl
fix(psalm): named attribute argument
dd0099c 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl ArtificialOwl mentioned this pull request Jul 29, 2024
Merged
11 tasks
@solracsf solracsf added the 3. to review Waiting for reviews label Jul 29, 2024
@provokateurin provokateurin mentioned this pull request Jul 29, 2024
Closed
4 tasks
@ArtificialOwl ArtificialOwl merged commit 1082164 into master Jul 29, 2024
169 checks passed
@ArtificialOwl ArtificialOwl deleted the fix/noid/named-attribute-argument branch July 29, 2024 13:34
@blizzz blizzz mentioned this pull request Jul 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provokateurin provokateurin provokateurin approved these changes

@solracsf solracsf solracsf approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArtificialOwl @solracsf @provokateurin