[stable27] fix: try to find non-recursive share source #46882
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| $this->cache = null; | ||
| break; | ||
| } | ||
| if (!$this->nonMaskedStorage) { |
Check notice
Code scanning / Psalm
DocblockTypeContradiction Note
| $this->cache = null; | ||
| break; | ||
| } | ||
| if (!$this->nonMaskedStorage) { |
Check notice
Code scanning / Psalm
DocblockTypeContradiction Note
AndyScherzinger
changed the title
instead of always picking the first one, try to find one that won't blow up Signed-off-by: Robin Appelman <robin@icewind.nl>
AndyScherzinger
force-pushed
the
try-non-recursive-source-27
branch
from
86c826a
to
4e9cf15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test backport of #46881