Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files_versions): Catch constraint error on version insertion #46887

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Jul 30, 2024

  • Resolves: #

Summary

Catch errors when inserting a version with same fileid and timestamp as the previous one, and retry with incremented timestamp.

Checklist

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc added bug 3. to review Waiting for reviews labels Jul 30, 2024
@come-nc come-nc added this to the Nextcloud 30 milestone Jul 30, 2024
@come-nc come-nc requested a review from artonge July 30, 2024 15:10
@come-nc come-nc self-assigned this Jul 30, 2024
@solracsf
Copy link
Member

solracsf commented Jul 30, 2024

A similar logic could be applied to Groupfolders? I can observe these Constraints Violations using Groupfolders too.
https://github.com/nextcloud/groupfolders/blob/1933ff67ac47fabcd67b7f51e0318d3a11725089/lib/Versions/VersionsBackend.php#L110

@blizzz blizzz mentioned this pull request Aug 1, 2024
This was referenced Aug 5, 2024
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
@skjnldsv skjnldsv merged commit 1fa9d39 into master Aug 14, 2024
167 of 169 checks passed
@skjnldsv skjnldsv deleted the fix/versions-catch-insertion-error branch August 14, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants