fix(files): Set container for file list actions #46896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
nfebe,
Pytal and
sorbaugh
and removed request for
a team
|
/backport to stable29 |
|
/backport to stable28 |
skjnldsv
approved these changes
Jul 31, 2024
sorbaugh
approved these changes
Jul 31, 2024
This is needed to ensure the actions are rendered below dialogs which will have the body as the container. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/files-actions-contaniner
branch
from
2171f58
to
1bedc2c
Compare
AndyScherzinger
approved these changes
Jul 31, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reported by @jospoortvliet
This is needed to ensure the actions are rendered below dialogs which will have the body as the container.
Now it looks like this:
Checklist