Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable26] fix: write object to the correct urn when moving from another storage to object store #47488

Open
wants to merge 4 commits into
base: stable26
Choose a base branch
from
Open

[stable26] fix: write object to the correct urn when moving from another storage to object store #47488

wants to merge 4 commits into from
+254 −0

Commits on Nov 6, 2024

  1. fix: write object to the correct urn when moving from another storage… 

    … to object store

Signed-off-by: Robin Appelman <robin@icewind.nl>
    @icewind1991 @artonge
    icewind1991 authored and artonge committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    bb61efb View commit details
    Browse the repository at this point in the history

  2. perf(ObjectStoreStorage): Improve (slow) move on same object bucket 

    This commit fixes the issue #47856. When you upload a file into a group folder and when you use a single S3 bucket as primary storage, the final move operation hangs for a long time. In the background, Nextcloud initiates a copy-delete sequence from the bucket into the bucket, with causes a lot unnecessary overhead. Nextcloud thinks that the file must be imported to another storage and does not recognize that everything is done on the same object bucket. In that case, the import step can be completely skipped, which saves time, network bandwidth and reduces the load on the object storage.

The behavior improves a lot with #46013. However, there are still some put messages that are being sent to the object storage when you use an object storage as primary storage and upload files into a group folder.

Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Christoph Fiehe <c.fiehe@eurodata.de>
    @provokateurin @artonge
    2 people authored and artonge committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    37e8452 View commit details
    Browse the repository at this point in the history

  3. fix(tests): Fix most obvious errors in ObjectStore tests 

    Some are still failing

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
    @come-nc @artonge
    come-nc authored and artonge committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    71c3b50 View commit details
    Browse the repository at this point in the history

  4. fix: rework move into object store to better preserve fileids 

    Signed-off-by: Robin Appelman <robin@icewind.nl>
    @icewind1991 @artonge
    icewind1991 authored and artonge committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    4c95ba9 View commit details
    Browse the repository at this point in the history