fix(Storage): Fix method docs inheritance #48080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
requested review from
a team,
Altahrim,
artonge and
sorbaugh
and removed request for
a team
|
/backport to stable30 |
|
/backport to stable29 |
|
/backport to stable28 |
|
Will wait for #48009 |
come-nc
approved these changes
Sep 16, 2024
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
changed the base branch from
master
to
fix/storage/get-owner-false
provokateurin
force-pushed
the
fix/storage/method-docs-inheritance
branch
from
e050563
to
d2d1e32
Compare
icewind1991
approved these changes
Sep 17, 2024
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#47798
Summary
Inheriting methods must not set their own doc blocks in order to properly inherit from IStorage.
Some of the docblocks were also messed up like
@param \OC\Files\Storage\Storage|null (optional) the storage to pass to the cachewhich doesn't list the name of the parameter which really messed with psalm.Checklist