Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Storage): Document getOwner() can return false #48094

Merged
merged 2 commits into from
Sep 17, 2024
Merged

fix(Storage): Document getOwner() can return false #48094

merged 2 commits into from
Sep 17, 2024

Conversation

provokateurin
Copy link
Member

@provokateurin provokateurin commented Sep 16, 2024 •
edited
Loading

Summary

The return type of getOwner() was never specified, but all implementations already treat it as string|false.

Checklist

@provokateurin provokateurin added bug 3. to review Waiting for reviews labels Sep 16, 2024
@provokateurin provokateurin added this to the Nextcloud 31 milestone Sep 16, 2024
@provokateurin provokateurin requested review from a team, Altahrim, yemkareems and come-nc and removed request for a team September 16, 2024 14:02
@provokateurin
Copy link
Member Author

/backport to stable30

@provokateurin
Copy link
Member Author

/backport to stable29

@provokateurin
Copy link
Member Author

/backport to stable28

@provokateurin provokateurin mentioned this pull request Sep 16, 2024
Draft
come-nc
come-nc approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you wait for #48009 to avoid conflicts in there?

@provokateurin
Copy link
Member Author

Will do!

@provokateurin provokateurin marked this pull request as draft September 16, 2024 18:36
@come-nc
Copy link
Contributor

come-nc commented Sep 16, 2024

Can you wait for #48009 to avoid conflicts in there?

Was merged, got you a few conflicts.

@provokateurin provokateurin marked this pull request as ready for review September 16, 2024 19:12
@provokateurin
Copy link
Member Author

Failure probably related :/

@provokateurin
fix(Storage): Document getOwner() can return false
8ca6fca 
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin
fix(Files): Handle getOwner() returning false
dc13f9c 
Signed-off-by: provokateurin <kate@provokateurin.de>
@skjnldsv skjnldsv merged commit 57a5baa into master Sep 17, 2024
172 of 174 checks passed
@skjnldsv skjnldsv deleted the fix/storage/get-owner-false branch September 17, 2024 08:44
This was referenced Sep 17, 2024
Closed
Closed
@backportbot backportbot bot mentioned this pull request Sep 17, 2024
Closed
2 tasks
This was referenced Sep 18, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim was automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
3 participants
@provokateurin @come-nc @skjnldsv