Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Move storage constructor to specific interface #48111

Merged
merged 3 commits into from
Sep 23, 2024
Merged

fix: Move storage constructor to specific interface #48111

merged 3 commits into from
Sep 23, 2024

Commits on Sep 23, 2024

  1. fix: Move storage constructor to specific interface 

    That allows Wrappers to use DI and not care about the constructor

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
    @come-nc
    come-nc committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    94b0a0e View commit details
    Browse the repository at this point in the history

  2. chore: use a proper @param tag for IConstructableStorage constructo… 

    …r parameter

Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
    @come-nc @provokateurin
    come-nc and provokateurin authored Sep 23, 2024
    Configuration menu
    Copy the full SHA
    eac9255 View commit details
    Browse the repository at this point in the history

  3. fix(tests): Fix test to remove call to non-existing constructor 

    Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
    @come-nc
    come-nc committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    b8ab560 View commit details
    Browse the repository at this point in the history