fix(caldav): explicitly check from component types #48131
+14
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miaulalala
requested review from
ChristophWurst and
tcitworld
as code owners
miaulalala
requested review from
st3iny,
tcitworld,
a team,
Altahrim,
skjnldsv and
yemkareems
and removed request for
ChristophWurst,
tcitworld and
a team
miaulalala
added
3. to review
|
/backport to stable30 |
|
/backport to stable29 |
|
/backport to stable28 |
ChristophWurst
approved these changes
Sep 17, 2024
Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
force-pushed
the
fix/filter-for-components-explicitly
branch
from
b90e8f0
to
a65cf51
Compare
|
Could you make the PR description a bit more verbose? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ignore everything but the specific component types that are defined as valid in the RFC. We should only denormalize data that is actually valid, and skip any invalid data structures. Otherwise we run into the danger of returning trash data.
TODO
Checklist