Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(settings): Ask for authentication before action on sessions #48168

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(settings): Ask for authentication before action on sessions #48168

wants to merge 1 commit into from
+142 −15

Conversation

lithrel
Copy link

@lithrel lithrel commented Sep 18, 2024

Summary

  • Ask for authentication on update/delete/wipe action on sessions
  • Adapt dialog messages according to selected action

Checklist

@lithrel lithrel force-pushed the fix/auth-on-sess-remove-39390 branch from 705fb3c to ad42dcb Compare September 18, 2024 12:07
@lithrel
fix(settings): Ask for authentication before action on sessions
6e3f569 
- Ask authentication on update/delete/wipe
- Adapt dialog message to action

Signed-off-by: Florent Hernandez <flo@flhz.is>
@lithrel lithrel force-pushed the fix/auth-on-sess-remove-39390 branch from f572861 to 6e3f569 Compare September 27, 2024 08:52
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feedback-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ask for authentication before removing 'Device & Sessions'
1 participant
@lithrel