-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make systemtags public visible #48206
base: master
Are you sure you want to change the base?
Conversation
7244306
to
e3a0f90
Compare
ba84f93
to
33403e1
Compare
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
663268a
to
9d535f6
Compare
@@ -197,7 +197,7 @@ public function __construct(IRequest $request, string $baseUri) { | |||
} | |||
|
|||
// system tags plugins | |||
$this->server->addPlugin(\OC::$server->get(SystemTagPlugin::class)); | |||
// $this->server->addPlugin(\OCP\Server::get(SystemTagPlugin::class)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
namespace OCA\SystemTags\Listeners; | ||
|
||
use OCA\Files\Event\LoadAdditionalScriptsEvent; | ||
use OCA\Systemtags\AppInfo\Application; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use OCA\Systemtags\AppInfo\Application; | |
use OCA\SystemTags\AppInfo\Application; |
@@ -112,7 +112,7 @@ public function deleteTags($tagIds); | |||
* | |||
* @since 9.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* @since 9.1.0 | |
* @since 9.1.0 | |
* @since 31.0.0 `$user` can be null to check anonymous permissions |
Also the typing above does not fit anymore, should be:
* @param IUser|null $user user to check permission for
fix #40364
Of course if the tag is made invisible in the settings, it will also apply.
I'm also thinking if it would make sense to NOT show restricted tags on public