new occ commands to manage system-tags for files #48277
Conversation
schaarsc
requested review from
skjnldsv,
Pytal,
ArtificialOwl,
come-nc,
artonge,
icewind1991,
szaimen,
susnux and
nfebe
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return 1; | ||
| } | ||
|
|
||
| $tags = $this->systemTagObjectMapper->getTagIdsForObjects($targetNode->getId(), 'files'); |
Check failure
Code scanning / Psalm
InvalidArgument
apps/files/lib/Command/TagAdd.php
Outdated
| ->setDescription('Add a system-tag to a file or folder') | ||
| ->addArgument('target', InputArgument::REQUIRED, "file id or path") | ||
| ->addArgument('tags', InputArgument::REQUIRED, "Name of the tag(s) to add, comma separated") | ||
| ->addArgument('access', InputArgument::REQUIRED, 'access level of the tag (public, restricted or invisible)'); |
There was a problem hiding this comment.
It feels weird that access is required for assigning an existing tag
There was a problem hiding this comment.
I think it is required because
- the same tagName can exist with different access level
- I want to work around the missing exif support (Show and edit EXIF Tags photos#226) by automatically creating the tags if it does not exist
There was a problem hiding this comment.
I want to work around the missing exif support (nextcloud/photos#226) by automatically creating the tags if it does not exist
We do support EXIF data, they are currently stored with the FilesMetadata API: https://github.com/nextcloud/photos/blob/f70a0486642e166c69bdd45a480288e05ba5faa9/lib/Listener/ExifMetadataProvider.php
There was a problem hiding this comment.
please replace EXIF with metadata/xmp...
I'm using the exiftool to extract metadata. The tool is able to extract the XMP information and TagsList is part of XMP, not EXIF
ExifMetadataProvider does indeed store the EXIF part of the metadata, but this only includes things like GPS, Time, size,...
apps/files/lib/Command/TagAdd.php
Outdated
| * SPDX-FileCopyrightText: Nextcloud GmbH and Nextcloud contributors | ||
| * SPDX-License-Identifier: AGPL-3.0-or-later | ||
| */ | ||
| namespace OCA\Files\Command; |
There was a problem hiding this comment.
These commands should be in the systemtags application, not files.
There was a problem hiding this comment.
sure, I can move the commands to tag, if you prefer that.
since the objectType is hardcoded to 'files', I'd suggest
- tag:files:add
- tag:files:delete
- tag:files:delete-all
if that is ok
Resolve nextcloud#32735 Signed-off-by: schaarsc <schaarsc@users.noreply.github.com>
schaarsc
force-pushed
the
feature/32735-occ-add-tag-to-file-master
branch
from
34cde37
to
819385c
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
adds the following commands to the files app:
files:tag-add <target> <tags> <access>files:tag-delete <target> <tags> <access>files:tag-delete-all <target>TODO
Checklist