[stable26] fix(dav): Always respond custom error page on exceptions #48303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
artonge
changed the title
artonge
force-pushed
the
backport/48297/stable26
branch
from
81dac53
to
8eacf8d
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } else { | ||
| $templateName = 'xml_exception'; | ||
| $renderAs = null; | ||
| $this->server->httpResponse->setHeader('Content-Type', 'application/xml; charset=utf-8'); |
Check notice
Code scanning / Psalm
PossiblyNullPropertyFetch Note
| } else { | ||
| $templateName = 'xml_exception'; | ||
| $renderAs = null; | ||
| $this->server->httpResponse->setHeader('Content-Type', 'application/xml; charset=utf-8'); |
Check notice
Code scanning / Psalm
PossiblyNullReference Note
| $content = new OC_Template('core', $templateName, 'guest'); | ||
| $debug = $this->config->getSystemValueBool('debug', false); | ||
|
|
||
| $content = new OC_Template('core', $templateName, $renderAs); |
Check notice
Code scanning / Psalm
PossiblyNullArgument Note
| if (BrowserErrorPagePlugin::isBrowserRequest($request)) { | ||
| $this->server->addPlugin(new BrowserErrorPagePlugin()); | ||
| } | ||
| $this->server->addPlugin(new ErrorPagePlugin($this->request, \OC::$server->getConfig())); |
Check notice
Code scanning / Psalm
DeprecatedMethod Note
artonge
force-pushed
the
backport/48297/stable26
branch
from
8eacf8d
to
abca7fb
Compare
provokateurin
approved these changes
Sep 25, 2024
artonge
force-pushed
the
backport/48297/stable26
branch
from
abca7fb
to
b154be9
Compare
come-nc
approved these changes
Sep 26, 2024
artonge
force-pushed
the
backport/48297/stable26
branch
5 times, most recently
from
d4679a1
to
b33694a
Compare
Signed-off-by: Louis Chemineau <louis@chmn.me>
The `<?xml` tag is interpreted as PHP short tags, so this causes errors. Instead just print that part of the template. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Louis Chemineau <louis@chmn.me>
…utput Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
backport/48297/stable26
branch
from
b33694a
to
2a10014
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #48297
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.