Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(files_versions): Refactor function for lisibility #48325

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

solracsf
Copy link
Member

Checklist

@solracsf solracsf added 3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Sep 24, 2024
@solracsf solracsf added this to the Nextcloud 31 milestone Sep 24, 2024
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: typo
@kesselb
Copy link
Contributor

kesselb commented Sep 24, 2024

I don't consider that an improvement 🙈

Fine by me, but please fix the commit message ;)

@solracsf
Copy link
Member Author

solracsf commented Sep 24, 2024

Sure, opinions.
Mine is that moving from 40+ lines to 15 is more readable/maintainable and match perfectly...matches this usage, hence the PR (to be reviewed). 😄

What's wrong with the commit message? 🤔

@susnux susnux requested review from provokateurin and come-nc and removed request for skjnldsv and susnux September 24, 2024 19:23
@susnux
Copy link
Contributor

susnux commented Sep 24, 2024

Removed my assignment as this is php code style related which I would pass to @come-nc and @provokateurin for files backend

@kesselb
Copy link
Contributor

kesselb commented Sep 24, 2024

The commit type should be "refactoring" instead of "chore" https://github.com/angular/angular/blob/22b96b9/CONTRIBUTING.md#type.

lisbility => legibility or readability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants