Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better distinguish this parameter dedicated to internal shares #48561

Conversation

Jerome-Herbinet
Copy link
Member

Just check the commit

Targeted wording :
2024-10-03_16-33

  • Resolves: #

Summary

TODO

  • ...

Checklist

@Jerome-Herbinet Jerome-Herbinet added design Design, UI, UX, etc. feature: sharing papercut Annoying recurring issue with possibly simple fix. feature: settings labels Oct 3, 2024
@Jerome-Herbinet Jerome-Herbinet force-pushed the Jerome-Herbinet-internal-shares-parameter-better-distinction branch from d0c3314 to 2059a4a Compare October 4, 2024 06:35
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good detail fix, thank you!

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
@skjnldsv skjnldsv force-pushed the Jerome-Herbinet-internal-shares-parameter-better-distinction branch from 62987b8 to 2164737 Compare November 9, 2024 13:35
@skjnldsv skjnldsv added the 4. to release Ready to be released and/or waiting for tests to finish label Nov 9, 2024
@skjnldsv skjnldsv merged commit ba81fbd into master Nov 9, 2024
110 of 118 checks passed
@skjnldsv skjnldsv deleted the Jerome-Herbinet-internal-shares-parameter-better-distinction branch November 9, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish design Design, UI, UX, etc. feature: settings feature: sharing feedback-requested papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants