feat(settings): migrate AppAPI ExApps management to settings #48665

andrey18106 · 2024-10-11T15:59:56Z

Summary

This PR migrates the UI for ExApp management to default Apps management page (settings app).
On backend side in settings app there is only addition for initial state for ExApps UI.
All ExApp related logic is in separate store that uses backend API part of AppAPI.

TODO

Requires chore: sync changes for Apps management migration to settings app_api#417 AppAPI side changes
Backport both to stable30

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)

bigcat88

Checked, the functionality works.

Note for future reviewers: a backport of this pull request will be included in version 30.0.2, the merge is planned to be right after the release of 30.0.1, so that everyone has enough time to test.

susnux

Nothing very critical but a lot of stuff summing up. See comments.

apps/settings/lib/Controller/AppSettingsController.php

apps/settings/src/components/AppList/AppItem.vue

apps/settings/src/mixins/AppManagement.js

apps/settings/src/store/app_api_apps.js

julien-nc

I'm not sure how likely it is to happen in a production environment but in my dev setup, some apps don't have a licence so when clicking on their list item, the sidebar does not open.

susnux · 2024-10-15T15:58:03Z

I'm not sure how likely it is to happen in a production environment but in my dev setup, some apps don't have a licence so when clicking on their list item, the sidebar does not open.

How can this happen? I was pretty sure the license is a required field in appinfo.xml thus the appstore should deny uploading such an app?

andrey18106 · 2024-10-16T23:21:26Z

I'm not sure how likely it is to happen in a production environment but in my dev setup, some apps don't have a licence so when clicking on their list item, the sidebar does not open.

How can this happen? I was pretty sure the license is a required field in appinfo.xml thus the appstore should deny uploading such an app?

It's a Test Deploy app, or any other manual-install type ExApp, it has no appstore information, only short info from DB.

susnux

Thank you! Some more comments, then it should be fine.

apps/settings/src/app-types.ts

apps/settings/src/components/AppList/AppDaemonBadge.vue

apps/settings/src/components/AppList/AppItem.vue

apps/settings/src/components/AppStoreSidebar/AppDetailsTab.vue

apps/settings/src/views/AppStoreSidebar.vue

susnux

I did not test with external app but code looks sane, as we need to backport (there will be a refactor on master soon, so lets get this in first).

andrey18106 · 2024-10-29T12:06:41Z

/compile

andrey18106 · 2024-10-29T13:24:00Z

/compile

Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com> # Conflicts: # apps/settings/lib/Controller/AppSettingsController.php # Conflicts: # apps/settings/lib/Controller/AppSettingsController.php

Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>

…s bundled Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>

Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

andrey18106 · 2024-10-29T18:54:53Z

/compile

andrey18106 · 2024-10-29T18:59:59Z

/backport to stable30

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

This PR synchronizes backend logic for ExAppFetcher and required changes for Apps management. ![Screen Shot 2024-10-14 at 17 01 48](https://github.com/user-attachments/assets/60667041-92b1-4d9e-a78a-9476a1271d1f) ## TODO - [ ] Merge with the server PR for settings app changes: nextcloud/server#48665 - [x] Remove old UI parts that are not needed anymore --------- Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com> Co-authored-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

andrey18106 requested review from julien-nc and bigcat88 October 11, 2024 15:59

andrey18106 mentioned this pull request Oct 11, 2024

chore: sync changes for Apps management migration to settings nextcloud/app_api#417

Merged

2 tasks

bigcat88 approved these changes Oct 14, 2024

View reviewed changes

susnux requested changes Oct 14, 2024

View reviewed changes

susnux added enhancement 3. to review Waiting for reviews feature: apps management labels Oct 14, 2024

susnux added this to the Nextcloud 31 milestone Oct 14, 2024

julien-nc reviewed Oct 14, 2024

View reviewed changes

susnux reviewed Oct 23, 2024

View reviewed changes

andrey18106 force-pushed the feat/settings/app_api_apps_management branch from 55f212e to 1ef44de Compare October 23, 2024 20:49

susnux approved these changes Oct 24, 2024

View reviewed changes

andrey18106 force-pushed the feat/settings/app_api_apps_management branch from 56e3f45 to b0e3af3 Compare October 29, 2024 12:06

andrey18106 force-pushed the feat/settings/app_api_apps_management branch from a8cd19e to fe354d3 Compare October 29, 2024 13:23

andrey18106 added 11 commits October 29, 2024 20:54

feat(app_api): add initial state data for AppAPI UI part

95b0630

Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com> # Conflicts: # apps/settings/lib/Controller/AppSettingsController.php # Conflicts: # apps/settings/lib/Controller/AppSettingsController.php

feat(settings): migrate AppAPI ExApps management (1)

7e31088

Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>

WIP: add Daemon badge in app sidebar (2)

a5291c6

Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>

WIP: use global mutation, since app_api_apps is namespaced

4f109be

Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>

WIP: add missing state checks

70a8d26

Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>

WIP: minor fixes

2f25546

Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>

fix(ci): resolve eslint errors

46e643b

Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>

fix(ci): suppress UndefinedClass for AppAPI related classes since it'…

3a840c1

…s bundled Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>

WIP: address review comments, small fixes

e4d5866

Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>

WIP: migrate to Pinia, minor fixes

c8b35fa

Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>

WIP: remove app_api_apps vuex store

6e75b41

Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>

andrey18106 and others added 7 commits October 29, 2024 20:54

fix: address review comments

8732755

Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>

fix(ci): psalm, suppress undefined for viewApps

a12b4da

Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>

fix(ci): fix eslint errors

93b5201

Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>

fix: loading state reactivity

dcc09ff

Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>

fix(ci): eslint fix, minor correction after rebase

24b221c

Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>

chore(assets): Recompile assets

2178f0b

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

chore(assets): Recompile assets

be23e7d

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

andrey18106 force-pushed the feat/settings/app_api_apps_management branch from 99bf58e to be23e7d Compare October 29, 2024 18:54

andrey18106 enabled auto-merge October 29, 2024 18:56

backportbot bot added the backport-request label Oct 29, 2024

andrey18106 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 29, 2024

chore(assets): Recompile assets

c2f1c3d

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

andrey18106 merged commit d266779 into master Oct 29, 2024
177 checks passed

andrey18106 deleted the feat/settings/app_api_apps_management branch October 29, 2024 19:24

backportbot bot mentioned this pull request Oct 29, 2024

[stable30] feat(settings): migrate AppAPI ExApps management to settings #48988

Merged

2 tasks

backportbot bot removed the backport-request label Oct 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(settings): migrate AppAPI ExApps management to settings #48665

feat(settings): migrate AppAPI ExApps management to settings #48665

andrey18106 commented Oct 11, 2024 •

edited

Loading

bigcat88 left a comment •

edited

Loading

susnux left a comment

julien-nc left a comment

susnux commented Oct 15, 2024

andrey18106 commented Oct 16, 2024

susnux left a comment

susnux left a comment

andrey18106 commented Oct 29, 2024

andrey18106 commented Oct 29, 2024

andrey18106 commented Oct 29, 2024

andrey18106 commented Oct 29, 2024

feat(settings): migrate AppAPI ExApps management to settings #48665

feat(settings): migrate AppAPI ExApps management to settings #48665

Conversation

andrey18106 commented Oct 11, 2024 • edited Loading

Summary

TODO

Checklist

bigcat88 left a comment • edited Loading

Choose a reason for hiding this comment

susnux left a comment

Choose a reason for hiding this comment

julien-nc left a comment

Choose a reason for hiding this comment

susnux commented Oct 15, 2024

andrey18106 commented Oct 16, 2024

susnux left a comment

Choose a reason for hiding this comment

susnux left a comment

Choose a reason for hiding this comment

andrey18106 commented Oct 29, 2024

andrey18106 commented Oct 29, 2024

andrey18106 commented Oct 29, 2024

andrey18106 commented Oct 29, 2024

andrey18106 commented Oct 11, 2024 •

edited

Loading

bigcat88 left a comment •

edited

Loading