Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/48678/restore dav error response #49004

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Bug/48678/restore dav error response #49004

wants to merge 3 commits into from
+76 −89

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Oct 30, 2024

  • Resolves: #

Summary

TODO

  • ...

Checklist

@kesselb kesselb force-pushed the bug/48678/restore-dav-error-response branch 2 times, most recently from 921e87d to 5e998fb Compare October 30, 2024 17:13
@kesselb
Revert "fix: Override start method of \Sabre\DAV\Server to remove exc…
a7bd52e 
…eption output"

This reverts commit e202896.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb
Revert "fix: Drop unnecessary exit"
ca197ef 
This reverts commit d2bf361.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb
Revert "fix(dav): Always respond custom error page on exceptions"
305cf4a 
This reverts commit 9992e7d.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb force-pushed the bug/48678/restore-dav-error-response branch from 5e998fb to 305cf4a Compare October 30, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miaulalala miaulalala Awaiting requested review from miaulalala miaulalala will be requested when the pull request is marked ready for review miaulalala is a code owner

@st3iny st3iny Awaiting requested review from st3iny st3iny will be requested when the pull request is marked ready for review st3iny is a code owner

@SebastianKrupinski SebastianKrupinski Awaiting requested review from SebastianKrupinski SebastianKrupinski will be requested when the pull request is marked ready for review SebastianKrupinski is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
2. developing Work in progress bug feature: dav
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kesselb @skjnldsv