Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(QBMapper): Fix findEntities() return type to be list<T> #49114

Merged
merged 1 commit into from
Nov 7, 2024
Merged

fix(QBMapper): Fix findEntities() return type to be list<T> #49114

merged 1 commit into from
Nov 7, 2024

Conversation

provokateurin
Copy link
Member

Summary

Found in nextcloud/spreed#13711.

Checklist

@provokateurin
fix(QBMapper): Fix findEntities() return type to be list<T>
2c65d0c 
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin added this to the Nextcloud 31 milestone Nov 6, 2024
come-nc
come-nc approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use yieldEntities anyway :-P

@nickvergessen nickvergessen merged commit c6002ed into master Nov 7, 2024
177 checks passed
@nickvergessen nickvergessen deleted the fix/qbmapper/find-entities-return-type branch November 7, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews technical debt
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
3 participants
@provokateurin @nickvergessen @come-nc