Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config): Add sysadmin level encription.available config #49202

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

feat(config): Add sysadmin level encription.available config #49202

wants to merge 3 commits into from
+43 −5

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented Nov 11, 2024

This is important because a user who has admin permissions who is not a sysadmin might enable encryption without knowing the full implications, the sysadmin should be able to prevent this.

Originally from

I know this is not 100% directly related, but in some cases, (sys)admin shoudl be able to completely disable encryption and its activation with config param like 'encryption_available' => false. If this was set to false (default as true) encryption (and its modules) could not be installed (or, at very least, activated) trough the WebUI or the CLI.

In this case, a message should also inform the user that encryption modules can't be installed or enabled because of that flag set.

#48829 (comment) by @solracsf

@nfebe
fix(settings): Prevent undefined related errors for encryption
038deb4 
`Object.entries([])` would return an empty array, that leads to the `find`
return undefined.

`encryptionReady` and `encryptionEnabled` also returns undefined when no
encryption module is available or functional (I guess).

Signed-off-by: nfebe <fenn25.fn@gmail.com>
@nfebe
fix(settings): Show feedback 4 server-sde encryption toggle
016738f 
Show visual feedback if user clicks on encryption toggle when it cannot be activated.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
@nfebe
feat(config): Add sysadmin level encription.available config
c84e30d 
This is important because a user who has admin permissions who is not a sysadmin
might enable encryption without knowing the full implications, the sysadmin
should be able to prevent this.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
@nfebe nfebe requested a review from solracsf November 11, 2024 15:40
@nfebe nfebe added pending documentation This pull request needs an associated documentation update and removed documentation labels Nov 11, 2024
@nfebe nfebe mentioned this pull request Nov 11, 2024
Open
@nfebe nfebe self-assigned this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solracsf solracsf Awaiting requested review from solracsf

At least 2 approving reviews are required to merge this pull request.

Assignees

@nfebe nfebe

Labels
customization pending documentation This pull request needs an associated documentation update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nfebe