Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): ensure valid mtime and fallback to crtime if defined #49225

Merged
merged 2 commits into from
Nov 14, 2024
Merged

fix(files): ensure valid mtime and fallback to crtime if defined #49225

merged 2 commits into from
Nov 14, 2024
+18 −4

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Nov 12, 2024 •
edited
Loading

Fix #48312
Best with nextcloud-libraries/nextcloud-files#1115 (but not required)

Steps

  1. Upload a file image.jpg (or whatever)
  2. Ensure mtime is invalid
UPDATE `filecache` SET `mtime` = '0' WHERE `filecache`.`path` = 'files/image.jpg';
  1. Load the files app
  2. See error
    image

Result

image

@skjnldsv skjnldsv added this to the Nextcloud 31 milestone Nov 12, 2024
@skjnldsv skjnldsv requested review from susnux and a team November 12, 2024 11:00
@skjnldsv skjnldsv self-assigned this Nov 12, 2024
@skjnldsv skjnldsv requested review from artonge and sorbaugh and removed request for a team November 12, 2024 11:01
@skjnldsv skjnldsv mentioned this pull request Nov 12, 2024
Merged
@skjnldsv skjnldsv requested a review from nfebe November 12, 2024 11:01
@skjnldsv skjnldsv mentioned this pull request Nov 12, 2024
Closed
8 tasks
@skjnldsv
Copy link
Member Author

/backport to stable30

@skjnldsv
Copy link
Member Author

/backport to stable29

@skjnldsv
Copy link
Member Author

/backport to stable28

@skjnldsv
Copy link
Member Author

/compile rebase

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 14, 2024
skjnldsv and others added 2 commits November 14, 2024 13:32
@skjnldsv @nextcloud-command
fix(files): ensure valid mtime and fallback to crtime if defined
42c245c 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@nextcloud-command
chore(assets): Recompile assets
394ca87 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv skjnldsv merged commit cba4673 into master Nov 14, 2024
118 checks passed
@skjnldsv skjnldsv deleted the fix/invalid-mtime branch November 14, 2024 13:57
This was referenced Nov 14, 2024
Draft
Draft
@backportbot backportbot bot mentioned this pull request Nov 14, 2024
Draft
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provokateurin provokateurin provokateurin approved these changes

@nfebe nfebe nfebe approved these changes

@susnux susnux Awaiting requested review from susnux

@artonge artonge Awaiting requested review from artonge artonge was automatically assigned from nextcloud/server-frontend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-frontend

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: files
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.

[Bug]: files.ts:77 RangeError: Invalid time value
4 participants
@skjnldsv @nfebe @provokateurin @nextcloud-command