[stable29] Fix remaining readdir() calls in loops with undesirable false evaluation potential #49228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -261,7 +261,7 @@ | |||
| } | |||
|
|
|||
| $dh = $this->opendir($path); | |||
| while ($file = readdir($dh)) { | |||
| while (($file = readdir($dh)) !== false) { | |||
Check notice
Code scanning / Psalm
PossiblyFalseArgument Note
| @@ -527,7 +527,7 @@ | |||
| } | |||
|
|
|||
| $dh = $this->opendir($source); | |||
| while ($file = readdir($dh)) { | |||
| while (($file = readdir($dh)) !== false) { | |||
Check notice
Code scanning / Psalm
PossiblyFalseArgument Note
yemkareems
approved these changes
Nov 12, 2024
susnux
approved these changes
Nov 12, 2024
|
@yemkareems can you please remove the |
…luation potential Signed-off-by: Josh Richards <josh.t.richards@gmail.com> [skip ci]
Signed-off-by: yemkareems <yemkareems@gmail.com>
yemkareems
force-pushed
the
backport/38630/stable29
branch
from
1463e24
to
051af1a
Compare
@susnux for some reason |
susnux
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #38630
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.