perf(comments): Add a way to get comments for multiple objects at the same time #54409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
CarlSchwan
force-pushed
the
comments-db-multiple
branch
from
4b08704 to
9a7a0c2
Compare
CarlSchwan
requested review from
Altahrim,
nfebe and
salmart-dev
and removed request for
a team
CarlSchwan
force-pushed
the
comments-db-multiple
branch
2 times, most recently
from
c623447 to
17135e2
Compare
CarlSchwan
force-pushed
the
comments-db-multiple
branch
2 times, most recently
from
48fa3fb to
07fac3b
Compare
icewind1991
approved these changes
Aug 14, 2025
CarlSchwan
force-pushed
the
comments-db-multiple
branch
from
07fac3b to
f91fe6a
Compare
icewind1991
reviewed
Aug 15, 2025
CarlSchwan
force-pushed
the
comments-db-multiple
branch
from
f91fe6a to
7c10fdb
Compare
|
@CarlSchwan master has some changes from the preloading event branch, when you rebase you will need to do some adaptations. Let me know if you need help and when you're done ping me for a review! |
… same time Signed-off-by: Carl Schwan <carl.schwan@nextclound.com>
CarlSchwan
force-pushed
the
comments-db-multiple
branch
2 times, most recently
from
cd3ac4a to
daef65a
Compare
rebased :) |
Since we now have an easy way to fetch the comments count. Signed-off-by: Carl Schwan <carl.schwan@nextclound.com>
CarlSchwan
force-pushed
the
comments-db-multiple
branch
from
daef65a to
94e2af0
Compare
CarlSchwan
added
3. to review
nickvergessen
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Required for nextcloud/deck#7164
Checklist