Skip to content

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Oct 24, 2025

These methods had been on the implementation and are used in text for a long time already. They should be exposed on the public interface so we can cleanup the psalm baseline:

@juliusknorr juliusknorr requested a review from a team as a code owner October 24, 2025 19:30
@juliusknorr juliusknorr requested review from Altahrim, leftybournes, salmart-dev and yemkareems and removed request for a team October 24, 2025 19:30
Signed-off-by: Julius Knorr <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the fix/direct-editing-interface branch from 8951c3c to 027d1ca Compare October 24, 2025 20:09
Comment on lines +56 to +59
* @param string $filePath
* @param string|null $editorId
* @param int|null $fileId
* @return string
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are they required?


/**
* @since 33.0.0
* @return string
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants