Conversation
SebastianKrupinski
requested review from
Altahrim,
ArtificialOwl,
icewind1991 and
salmart-dev
and removed request for
a team
| if (str_starts_with($line, 'X-WR-CALNAME:')) { | ||
| $calendarName = substr($line, 13); | ||
| } elseif (str_starts_with($line, 'X-APPLE-CALENDAR-COLOR:')) { | ||
| $calendarColor = substr($line, 23); | ||
| } |
There was a problem hiding this comment.
Why relying on non-standard properties since you've already got this information in the calendar meta?
There was a problem hiding this comment.
This is for compatibility... the first version of the migrator only created a single ICS file with custom properties for the name... part of the improvements is the ".meta" file.
SebastianKrupinski
force-pushed
the
feat/improve-calendar-migrator
branch
from
d27c7f9 to
1899e5f
Compare
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
SebastianKrupinski
force-pushed
the
feat/improve-calendar-migrator
branch
from
1899e5f to
bad2541
Compare
|
/backport to stable33 |
ChristophWurst
requested review from
DerDreschner
and removed request for
Altahrim,
ArtificialOwl,
icewind1991 and
salmart-dev
apps/dav/tests/integration/UserMigration/CalendarMigratorTest.php
Outdated
Show resolved
Hide resolved
|
|
||
| $importSource->method('pathExists') | ||
| ->willReturnCallback(function (string $path) { | ||
| if ($path === 'dav/calendars/calendars.json') { |
There was a problem hiding this comment.
Why not making the constants public and use them here?
| $files = array_values(array_diff($files, ['.', '..'])); | ||
| $this->assertNotEmpty($files, 'No asset files found'); | ||
|
|
||
| // Load all ICS content and build calendars metadata |
There was a problem hiding this comment.
I think this could be removed? I mean the metadata is included in the .meta file for V2 exports.
There was a problem hiding this comment.
Are you talking about this:
$files = array_values(array_diff($files, ['.', '..']));
$this->assertNotEmpty($files, 'No asset files found');
Or the comment?
There was a problem hiding this comment.
I'm talking about the block that comes after the comment (manually building the metadata instead of only using the .meta file).
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
5 participants
Summary
Testing
Checklist
3. to review, feature component)stable32)