-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
chore!: drop jQuery UI and jQuery #57648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+538
−6,001
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
9c8f801
chore!(core): drop deprecated `OC.Settings`
susnux 16f4ff9
chore!(core): drop deprecated `OC.Dialogs.fileexists`
susnux b66292a
chore!(core): drop deprecated `OC.Notification`
susnux e14d97b
chore!(core): remove deprecated `OC.Apps`
susnux 503fad2
chore!(core): remove legacy `OC.registerMenu` and other menu helpers
susnux c89939f
chore!(core): remove handling of `.live-relative-timestamp` use `@nex…
susnux fd5108b
chore!(core): remove global snapper.js handling
susnux a32168b
chore!(core): remove legacy `OC.Files.Client`
susnux 00a5c02
chore!(core): remove legacy Backbone
susnux b0df06d
chore!(core): remove deprecated jQuery and jQuery UI
susnux 0b37d37
chore: compile assets
susnux File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| /** | ||
| * SPDX-FileCopyrightText: 2016 Nextcloud GmbH and Nextcloud contributors | ||
| * SPDX-License-Identifier: AGPL-3.0-or-later | ||
| */ | ||
|
|
||
| import { getCSPNonce } from '@nextcloud/auth' | ||
| import { FilePickerType, getFilePickerBuilder } from '@nextcloud/dialogs' | ||
| import { t } from '@nextcloud/l10n' | ||
|
|
||
| __webpack_nonce__ = getCSPNonce() | ||
|
|
||
| window.OCP.Collaboration.registerType('file', { | ||
| typeString: t('files_sharing', 'Link to a file'), | ||
| typeIconClass: 'icon-files-dark', | ||
| async action() { | ||
| const filePicker = getFilePickerBuilder(t('files_sharing', 'Link to a file')) | ||
| .setType(FilePickerType.Choose) | ||
| .allowDirectories(true) | ||
| .build() | ||
|
|
||
| try { | ||
| const [node] = await filePicker.pickNodes() | ||
| return node!.fileid | ||
| } catch { | ||
| throw new Error('Cannot get fileinfo') | ||
| } | ||
| }, | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: Ideally we would migrate away to Node API. But
files_sharingis very tangled with fileinfo objects.So better to do it later in a follow up to not make this PR even worse (in terms of reviewability).