refactor(memoryinfo): use ini_parse_quantity for memory limit parsing#57734
Draft
joshtrichards wants to merge 6 commits intomasterfrom
Draft
refactor(memoryinfo): use ini_parse_quantity for memory limit parsing#57734joshtrichards wants to merge 6 commits intomasterfrom
joshtrichards wants to merge 6 commits intomasterfrom
Conversation
Refactor `MemoryInfo` to leverage PHP's (8.2+) native `ini_parse_quantity()` for parsing and converting `memory_limit` values. - Eliminates custom logic and unnecessary checks. - Fully aligns parsing with PHP's internal parsing behavior. - Fixes a bug where our support for `float` in this particular context was too generous, because on 32-bit systems PHP's own parsing of this value wraps. By switching to this new function we are literally checking from PHP's perspective rather than checking the user's intent. Checking actual effective config value is more appropriate in this context. Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
…r upload limits Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor
MemoryInfoto leverage PHP's (8.2+) nativeini_parse_quantity()for parsing and convertingmemory_limitvalues.floatin this particular context was too generous, because on 32-bit systems PHP's own parsing of this value wraps. By switching to this new function we are literally checking from PHP's perspective rather than checking the user's intent. Checking actual effective config value is more appropriate in this context.Refactor Util::uploadLimit(), maxUploadFilesize(), and related helpers to improve reliability, correctness, and standards alignment.
Refs:
TODO
server/lib/public/Util.php
Line 564 in 3f9849d
Checklist
3. to review, feature component)stable32)