Skip to content

feat: calendar read and write federation#58008

Open
SebastianKrupinski wants to merge 4 commits intomasterfrom
feat/calendar-federation-readwrite
Open

feat: calendar read and write federation#58008
SebastianKrupinski wants to merge 4 commits intomasterfrom
feat/calendar-federation-readwrite

Conversation

@SebastianKrupinski
Copy link
Contributor

@SebastianKrupinski SebastianKrupinski commented Feb 3, 2026

  • Resolves: # feature request

Summary

Testing

  • Federate two instances of NC
  • Share a calendar with user from instance A to another user on instance B
  • Update a event on instance B in calendar from instance A

Checklist

@SebastianKrupinski SebastianKrupinski self-assigned this Feb 3, 2026
@SebastianKrupinski SebastianKrupinski added the 2. developing Work in progress label Feb 3, 2026
@github-project-automation github-project-automation bot moved this to 🏗️ In progress in 💌 📅 👥 Groupware team Feb 3, 2026
@SebastianKrupinski SebastianKrupinski force-pushed the feat/calendar-federation-readwrite branch from 020d2bc to 8291d3c Compare February 3, 2026 02:39
@SebastianKrupinski SebastianKrupinski force-pushed the feat/calendar-federation-readwrite branch 2 times, most recently from 04a42b2 to fb1b0a2 Compare February 3, 2026 21:43
@SebastianKrupinski SebastianKrupinski added this to the Nextcloud 33 milestone Feb 3, 2026
@SebastianKrupinski SebastianKrupinski added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 3, 2026
@kesselb
Copy link
Contributor

kesselb commented Feb 4, 2026

The failing AppSettingsControllerTest is fixed by #58050

@SebastianKrupinski
Copy link
Contributor Author

AppSettingsControllerTest

Ty

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@SebastianKrupinski SebastianKrupinski force-pushed the feat/calendar-federation-readwrite branch from fb1b0a2 to 565d4c0 Compare February 4, 2026 20:50
@SebastianKrupinski SebastianKrupinski marked this pull request as ready for review February 5, 2026 14:32
@SebastianKrupinski SebastianKrupinski requested review from CarlSchwan, icewind1991, leftybournes and salmart-dev and removed request for a team February 5, 2026 14:32
@SebastianKrupinski
Copy link
Contributor Author

Up for review will fix psalm in the mean time

@ChristophWurst
Copy link
Member

@SebastianKrupinski tell us how this can be tested, please

@SebastianKrupinski
Copy link
Contributor Author

@SebastianKrupinski tell us how this can be tested, please

Okay, done, updated desciption

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@ChristophWurst ChristophWurst requested review from hamza221 and kesselb and removed request for CarlSchwan, icewind1991, leftybournes and salmart-dev February 10, 2026 15:17
@hamza221
Copy link
Contributor

Few remarks while testing the feature , in this context Bob is the owner (sharer), Alice is the receiver of the share :

  • When Alice quits the share, it doesn't update for Bob
  • Bob Unshares, doesn't delete for Alice
  • can't toggle edit permissions for federated shares
  • Alice doesn't see events from shared the calendar
  • Alice can't create events on the shared Calendar

I checked out both calendar and server Prs
No code review yet

@SebastianKrupinski
Copy link
Contributor Author

I checked out both calendar and server Prs No code review yet

Just to double check, did you checkout out both PR's on both instances?

@hamza221
Copy link
Contributor

I checked out both calendar and server Prs No code review yet

Just to double check, did you checkout out both PR's on both instances?

yes

@SebastianKrupinski
Copy link
Contributor Author

yes

Okay, apologies, found the issue, I accidentally didn't push the calendar settings change, fun of working on two instances at the same time...

@hamza221
Copy link
Contributor

hamza221 commented Feb 13, 2026

Notes from Yesterday's test:

  • Sharing, Editing privileges, read, Edit: work as expected ✅
  • Quitting a share, Unsharing -> don't update for the other user 🚫 (Can be fixed in a followup )
  • When running sync command with one of the received shared calendars being unshared from the owner (doesn't update because of Point 2 👆🏼)
Failed to sync calendar f98f0703147a5feeb0180ca9351b1783: Client error: `REPORT http://nextcloud.local/remote.php/dav/remote-calendars/YWRtaW5AaHR0cDovL3N0YWJsZTMzLmxvY2Fs/federated_shared_by_admin` resulted in a `401 Unauthorized` response:
<?xml version="1.0" encoding="utf-8"?>
<d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
  <s:exception>Sabre\DA (truncated...) 

Should be fixed or caught and handled

@blizzz blizzz modified the milestones: Nextcloud 33, Nextcloud 34 Feb 16, 2026
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@SebastianKrupinski SebastianKrupinski force-pushed the feat/calendar-federation-readwrite branch from 2447722 to 6fb0f9f Compare February 17, 2026 15:29
@SebastianKrupinski
Copy link
Contributor Author

@hamza221

* Quitting a share, Unsharing -> don't update for the other user 🚫  (Can be fixed in a followup )

This is done on re-sync, if the request in unauthorized, its removed

* When running sync command with one of the received shared calendars being unshared from the owner (doesn't update because of Point 2 👆🏼)

This was already being caught an handled the original implementation was re throwing the error now we log only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 🏗️ In progress

Development

Successfully merging this pull request may close these issues.

6 participants