[stable33] perf(mounts): Tear down file system after getting each root

build/psalm-baseline.xml

@@ -3777,7 +3777,6 @@
   </file>
   <file src="lib/private/Files/Node/Root.php">
     <LessSpecificReturnStatement>
-      <code><![CDATA[$folders]]></code>
       <code><![CDATA[$this->mountManager->findByNumericId($numericId)]]></code>
       <code><![CDATA[$this->mountManager->findByStorageId($storageId)]]></code>
       <code><![CDATA[$this->mountManager->findIn($mountPoint)]]></code>

lib/private/Files/Node/Folder.php

@@ -338,7 +338,7 @@ public function getAppDataDirectoryName(): string {
 	 * in.
 	 *
 	 * @param int $id
-	 * @return array
+	 * @return list<Node>
 	 */
 	protected function getByIdInRootMount(int $id): array {
 		if (!method_exists($this->root, 'createNode')) {

lib/private/Files/Node/Root.php

@@ -19,6 +19,7 @@
 use OCP\Cache\CappedMemoryCache;
 use OCP\EventDispatcher\IEventDispatcher;
 use OCP\Files\Cache\ICacheEntry;
+use OCP\Files\Config\ICachedMountInfo;
 use OCP\Files\Config\IUserMountCache;
 use OCP\Files\Events\Node\FilesystemTornDownEvent;
 use OCP\Files\IRootFolder;
@@ -388,7 +389,7 @@ public function getFirstNodeByIdInPath(int $id, string $path): ?INode {
 				}
 			}
 		}
-		$node = current($this->getByIdInPath($id, $path));
+		$node = current($this->getByIdInPath($id, $path, true));
 		if (!$node) {
 			return null;
 		}
@@ -400,10 +401,10 @@ public function getFirstNodeByIdInPath(int $id, string $path): ?INode {
 	}
 
 	/**
-	 * @param int $id
-	 * @return Node[]
+	 * @return list<INode>
+	 * @note $onlyFirst is not part of the public API, only used by getFirstNodeByIdInPath
 	 */
-	public function getByIdInPath(int $id, string $path): array {
+	public function getByIdInPath(int $id, string $path, bool $onlyFirst = false): array {
 		$mountCache = $this->getUserMountCache();
 		$setupManager = $this->mountManager->getSetupManager();
 		if ($path !== '' && strpos($path, '/', 1) > 0) {
@@ -426,72 +427,76 @@ public function getByIdInPath(int $id, string $path): array {
 		//
 		// so instead of using the cached entries directly, we instead filter the current mounts by the rootid of the cache entry
 
-		$mountRootIds = array_map(function ($mount) {
-			return $mount->getRootId();
-		}, $mountsContainingFile);
-		$mountRootPaths = array_map(function ($mount) {
-			return $mount->getRootInternalPath();
-		}, $mountsContainingFile);
-		$mountProviders = array_unique(array_map(function ($mount) {
-			return $mount->getMountProvider();
-		}, $mountsContainingFile));
-		$mountRoots = array_combine($mountRootIds, $mountRootPaths);
+		/** @var array<int, string> $mountRoots */
+		$mountRoots = [];
+		foreach ($mountsContainingFile as $mountInfo) {
+			$mountRoots[$mountInfo->getRootId()] = $mountInfo->getRootInternalPath();
+		}
 
-		$mountsContainingFile = array_filter(array_map($this->mountManager->getMountFromMountInfo(...), $mountsContainingFile));
+		$userManager = Server::get(IUserManager::class);
+		$foundMount = false;
+		$nodes = [];
+		foreach ($mountsContainingFile as $mountInfo) {
+			$mount = $this->mountManager->getMountFromMountInfo($mountInfo);
+			if ($mount === null) {
+				continue;
+			}
+			$foundMount = true;
 
-		if (count($mountsContainingFile) === 0) {
-			if ($user === $this->getAppDataDirectoryName()) {
-				$folder = $this->get($path);
-				if ($folder instanceof Folder) {
-					return $folder->getByIdInRootMount($id);
-				} else {
-					throw new \Exception('getByIdInPath with non folder');
-				}
+			$storage = $mount->getStorage();
+			if ($storage === null) {
+				continue;
 			}
-			return [];
-		}
 
-		$nodes = array_map(function (IMountPoint $mount) use ($id, $mountRoots) {
-			$rootInternalPath = $mountRoots[$mount->getStorageRootId()];
-			$cacheEntry = $mount->getStorage()->getCache()->get($id);
-			if (!$cacheEntry) {
-				return null;
+			$cacheEntry = $storage->getCache()->get($id);
+			if ($cacheEntry === false) {
+				continue;
 			}
 
+			$rootInternalPath = $mountRoots[$mount->getStorageRootId()];
+
 			// cache jails will hide the "true" internal path
 			$internalPath = ltrim($rootInternalPath . '/' . $cacheEntry->getPath(), '/');
 			$pathRelativeToMount = substr($internalPath, strlen($rootInternalPath));
 			$pathRelativeToMount = ltrim($pathRelativeToMount, '/');
 			$absolutePath = rtrim($mount->getMountPoint() . $pathRelativeToMount, '/');
-			$storage = $mount->getStorage();
-			if ($storage === null) {
-				return null;
-			}
 			$ownerId = $storage->getOwner($pathRelativeToMount);
 			if ($ownerId !== false) {
-				$owner = Server::get(IUserManager::class)->get($ownerId);
+				$owner = $userManager->get($ownerId);
 			} else {
 				$owner = null;
 			}
-			return $this->createNode($absolutePath, new FileInfo(
+			$node = $this->createNode($absolutePath, new FileInfo(
 				$absolutePath,
 				$storage,
 				$cacheEntry->getPath(),
 				$cacheEntry,
 				$mount,
 				$owner,
 			));
-		}, $mountsContainingFile);
 
-		$nodes = array_filter($nodes);
+			if (PathHelper::getRelativePath($path, $node->getPath()) !== null) {
+				$nodes[] = $node;
+				if ($onlyFirst) {
+					return $nodes;
+				}
+			}
+		}
 
-		$folders = array_filter($nodes, function (Node $node) use ($path) {
-			return PathHelper::getRelativePath($path, $node->getPath()) !== null;
-		});
-		usort($folders, function ($a, $b) {
-			return $b->getPath() <=> $a->getPath();
-		});
-		return $folders;
+		if (!$foundMount) {
+			if ($user === $this->getAppDataDirectoryName()) {
+				$folder = $this->get($path);
+				if ($folder instanceof Folder) {
+					return $folder->getByIdInRootMount($id);
+				} else {
+					throw new \Exception('getByIdInPath with non folder');
+				}
+			}
+			return [];
+		}
+
+		usort($nodes, static fn (Node $a, Node $b): int => $b->getPath() <=> $a->getPath());
+		return $nodes;
 	}
 
 	public function getNodeFromCacheEntryAndMount(ICacheEntry $cacheEntry, IMountPoint $mountPoint): INode {

lib/public/Files/IRootFolder.php

@@ -36,7 +36,7 @@ public function getUserFolder($userId);
 	 *
 	 * @param int $id
 	 * @param string $path
-	 * @return Node[]
+	 * @return list<Node>
 	 *
 	 * @since 24.0.0
 	 */