Skip to content

Comments

fix(dav): Use an exhaustive list for allowed serialized classes#58095

Merged
provokateurin merged 1 commit intomasterfrom
fix/exhaustive-list-for-serialized-classes
Feb 5, 2026
Merged

fix(dav): Use an exhaustive list for allowed serialized classes#58095
provokateurin merged 1 commit intomasterfrom
fix/exhaustive-list-for-serialized-classes

Conversation

@come-nc
Copy link
Contributor

@come-nc come-nc commented Feb 5, 2026

Summary

This is simpler and clearer than trying to guess namespace.

Checklist

@come-nc come-nc added this to the Nextcloud 34 milestone Feb 5, 2026
@come-nc come-nc self-assigned this Feb 5, 2026
@come-nc come-nc requested a review from a team as a code owner February 5, 2026 11:13
@come-nc come-nc requested review from leftybournes and salmart-dev and removed request for a team February 5, 2026 11:13
@come-nc come-nc added the 3. to review Waiting for reviews label Feb 5, 2026
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

This is simpler and clearer than trying to guess namespace.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the fix/exhaustive-list-for-serialized-classes branch from a39234c to 669ff56 Compare February 5, 2026 13:03
@come-nc
Copy link
Contributor Author

come-nc commented Feb 5, 2026

/backport to stable33

@come-nc
Copy link
Contributor Author

come-nc commented Feb 5, 2026

/backport to stable32

@provokateurin provokateurin merged commit 256e89b into master Feb 5, 2026
186 of 192 checks passed
@provokateurin provokateurin deleted the fix/exhaustive-list-for-serialized-classes branch February 5, 2026 22:51
@solracsf
Copy link
Member

solracsf commented Feb 5, 2026

/backport to stable33

1 similar comment
@come-nc
Copy link
Contributor Author

come-nc commented Feb 23, 2026

/backport to stable33

@come-nc
Copy link
Contributor Author

come-nc commented Feb 23, 2026

/backport to stable32

@backportbot
Copy link

backportbot bot commented Feb 23, 2026

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/58095/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 669ff56f

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/58095/stable32

Error: Failed to push branch backport/58095/stable32: remote: Invalid username or token. Password authentication is not supported for Git operations.
fatal: Authentication failed for 'https://github.com/nextcloud/server.git/'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants