Merged
Conversation
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
salmart-dev
requested review from
Altahrim,
ArtificialOwl,
come-nc and
icewind1991
and removed request for
a team
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable30 |
icewind1991
approved these changes
Feb 9, 2026
cristianscheid
approved these changes
Feb 9, 2026
provokateurin
approved these changes
Feb 16, 2026
This was referenced Feb 19, 2026
CarlSchwan
reviewed
Feb 19, 2026
|
|
||
| public function initialize(\Sabre\DAV\Server $server): void { | ||
| $server->on('afterMethod:*', [$this, 'afterMethod']); | ||
| $server->on('beforeMethod:*', [$this, 'beforeMethod']); |
Member
There was a problem hiding this comment.
Suggested change
| $server->on('beforeMethod:*', [$this, 'beforeMethod']); | |
| $server->on('beforeMethod:*', $this->beforeMethod(...)); |
For the next time ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sets the user id header in DAV responses in
beforeMethodinstead ofafterMethod, this ensures that if some plugins stop the event propagation, the user id header will still be set.Adds the same header in the redirect response when calling
GET /index.phpwhich redirects to the default app.Checklist
3. to review, feature component)stable32)