fix: user count frontend version#58398
Open
csilva1-eng wants to merge 1 commit intonextcloud:masterfrom
Open
Conversation
Signed-off-by: csilva1-eng <christophersilva656@gmail.com>
csilva1-eng
requested review from
skjnldsv,
susnux and
szaimen
and removed request for
a team
susnux
approved these changes
Feb 18, 2026
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
works for now but will break with Vue 3 migration (component then only allows numeric values)
Contributor
|
/backport to stable33 |
Contributor
|
/backport to stable32 |
csilva1-eng
commented
Feb 18, 2026
| const userCount = computed(() => { | ||
| const count = store.getters.getUserCount | ||
|
|
||
| return count >= 999 ? '999+' : 0 |
Author
There was a problem hiding this comment.
Mistake on this line. Meant to be
return count >= 999 ? '999+' : count
Contributor
There was a problem hiding this comment.
Suggested change
| return count >= 999 ? '999+' : 0 | |
| return count >= 999 ? '999+' : count |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Saw that the previous pull request to this had an issue with working in the backend. I changed the line in the frontend as suggested to avoid that issue. This is my first ever open source contribution! Apologies in advance for any mistakes I may have made.
Checklist
3. to review, feature component)stable32)